[CI Bot] environment lockfiles auto-update #6597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![scitools-ci[bot]](https://avatars.githubusercontent.com/in/212324?s=60&v=4){kind=small}
github-actions
bot
added
the
benchmark_this
⏱️ Performance Benchmark Report: 4068d5dPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 4068d5dPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 4068d5dPerformance shiftsFull benchmark resultsGenerated by GHA run |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
b742c2c to
afdf410
Compare
⏱️ Performance Benchmark Report: e98d344Performance shiftsFull benchmark resultsGenerated by GHA run |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
afdf410 to
befcac5
Compare
⏱️ Performance Benchmark Report: fcfcc10Performance shiftsFull benchmark resultsGenerated by GHA run |
bjlittle
force-pushed
the
auto-update-lockfiles
branch
2 times, most recently
from
c0690ca to
57ebd0e
Compare
bjlittle
removed
the
benchmark_this
⏱️ Performance Benchmark Report: e583ffePerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: a120396Performance shiftsFull benchmark resultsGenerated by GHA run |
scitools-ci
bot
force-pushed
the
auto-update-lockfiles
branch
from
57ebd0e to
182dbdc
Compare
github-actions
bot
added
the
benchmark_this
⏱️ Performance Benchmark Report: ff87d44Performance shiftsFull benchmark resultsGenerated by GHA run |
|
A single graphical test is failing for wind barbs plot The difference is highlighting that two vectors have a difference of half a barb, which requires further investigation to determine the root cause: 
|
|
Those barb tests start by defining a magnitude as "scale" iris/lib/iris/tests/integration/plot/test_vector_plots.py Lines 104 to 106 in 345eea3 then u, v further get multiplied by 30 iris/lib/iris/tests/integration/plot/test_vector_plots.py Lines 195 to 197 in 345eea3 So our input magnitudes are basically After all the various transformations, Matplotlib by default rounds magnitudes to the nearest 5 (see the rounding and barb_increments keywords in the docs). So it seems to me that our input magnitudes are ideally chosen to be sensitive to floating point errors. |
|
I have not checked, but the change might plausibly have been caused by something as simple as SciTools/cartopy#2509 |
|
@rcomer This is indeed the smoking gun and I've been able to verify that. Awesome spot 🤩 As you said, the magnitudes that we're pumping into the test are just on the edge of where (Pdb) uu = u.flatten()
(Pdb) vv = v.flatten()
(Pdb) vm = (uu**2 + vv**2)**0.5
(Pdb) vmh = np.hypot(uu, vv)
(Pdb) vm
array([30. , 37.5, 45. , 52.5, 60. , 30. , 37.5, 45. , 52.5, 60. , 30. ,
37.5, 45. , 52.5, 60. , 30. , 37.5, 45. , 52.5, 60. , 30. , 37.5,
45. , 52.5, 60. , 30. , 37.5, 45. , 52.5, 60. ])
(Pdb) vmh
array([30. , 37.5, 45. , 52.5, 60. , 30. , 37.5, 45. , 52.5, 60. , 30. ,
37.5, 45. , 52.5, 60. , 30. , 37.5, 45. , 52.5, 60. , 30. , 37.5,
45. , 52.5, 60. , 30. , 37.5, 45. , 52.5, 60. ])
(Pdb) vmd = vm - vmh
(Pdb) vm == vmh
array([ True, True, True, True, True, True, False, False, False,
True, True, True, True, False, True, True, True, True,
True, True, True, True, True, True, True, True, False,
True, True, True])
(Pdb) vmd
array([ 0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00,
0.00000000e+00, 0.00000000e+00, 7.10542736e-15, -7.10542736e-15,
-7.10542736e-15, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00,
0.00000000e+00, 7.10542736e-15, 0.00000000e+00, 0.00000000e+00,
0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00,
0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00,
0.00000000e+00, 0.00000000e+00, -7.10542736e-15, 0.00000000e+00,
0.00000000e+00, 0.00000000e+00])The The fix is to marginally up-scale the data enough to firmly place the magnitudes comfortably within the expected |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6597 +/- ##
==========================================
- Coverage 90.33% 90.29% -0.05%
==========================================
Files 91 91
Lines 24465 24465
Branches 4568 4568
==========================================
- Hits 22100 22090 -10
- Misses 1597 1607 +10
Partials 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjlittle
removed
the
benchmark_this
* fix barb magnitude binning flip/flop * review actions * review action: add future comment
bjlittle
force-pushed
the
auto-update-lockfiles
branch
from
90c5318 to
c20e8b7
Compare
github-actions
bot
added
the
benchmark_this
bjlittle
approved these changes
Sep 5, 2025
⏱️ Performance Benchmark Report: d444b40Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: bc53ce2Performance shiftsFull benchmark resultsGenerated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lockfiles updated to the latest resolvable environment.
If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.